Re: pgsql/src/bin/pg_ctl pg_ctl.sh

> Bruce Momjian - CVS writes:
>
> > CVSROOT: /home/projects/pgsql/cvsroot
> > Module name: pgsql
> > Changes by: momjian(at)hub(dot)org 01/07/11 12:16:53
> >
> > Modified files:
> > src/bin/pg_ctl : pg_ctl.sh
> >
> > Log message:
> > Move export PGDATA to the proper place.
>
> This is completely broken. The old place was right.

Can you explain. Do we not want to export PGDATA for other programs we
run from this script?

> > Quote some variable substitutions.
>
> You don't need to quote the argument to 'case'. Please don't do that, it
> makes things less readable.

Well, I guess. I usually quote all variable mentions. I saw lots of
VAR=$1 which should be VAR="$1", right?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026