Re: pgsql/src/bin/pg_ctl pg_ctl.sh

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Bruce Momjian - CVS <momjian(at)hub(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/src/bin/pg_ctl pg_ctl.sh
Date: 2001-07-11 19:35:54
Message-ID: 200107111935.f6BJZsU29938@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> I wrote:
>
> > > Move export PGDATA to the proper place.
> >
> > This is completely broken. The old place was right.
>
> Correction: The new place also seems to be okay, but 'export VAR=stuff'
> is not portable, You need to split it into two commands.

Oh, yes you are totally correct. I am forgetting my old shell stuff.

>
> > > Quote some variable substitutions.
> >
> > You don't need to quote the argument to 'case'. Please don't do that, it
> > makes things less readable.
>
> Also, you don't need to quote the right side of
>
> FOO=$BAR

That is interesting. I just tried:

#$ X="1 2"
#$ Y=$X
#$ echo $X
1 2

When do I need quotes around variables then?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian - CVS 2001-07-11 19:36:42 pgsql/src backend/libpq/pg_hba.conf.sample bin ...
Previous Message Peter Eisentraut 2001-07-11 19:20:13 Re: pgsql/src/bin/pg_ctl pg_ctl.sh