Re: MD5

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Vince Vielhaber <vev(at)michvhf(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: MD5
Date: 2000-05-10 16:32:45
Message-ID: Pine.LNX.4.21.0005092335390.387-100000@localhost.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane writes:

> We've required ANSI-style prototypes all along. There are some other
> ANSI features we're willing to work around the lack of, like token
> pasting in macros ---

You must mean this stuff: :-)

[src/include/nodes/nodes.h]
| #define nodeTag(nodeptr) (((Node*)(nodeptr))->type)
|
| #define makeNode(_type_) ((_type_*) newNode(sizeof(_type_),T_##_type_))
| #define NodeSetTag(nodeptr,t) (((Node*)(nodeptr))->type = (t))
|
| #define IsA(nodeptr,_type_) (nodeTag(nodeptr) == T_##_type_)

There are some provisions for working around this, but evidently they're
not used uniformly (which leads me to believe that there's little need to
do so).

> so the real question is *what* ANSI features does the code require?

I think it's fair to assume an ANSI C89 compiler in the year 2000, based
on the fact that we don't actually seem to consciously avoid any
constructs I know of, modulo the Autoconf safety net.

--
Peter Eisentraut Sernanders väg 10:115
peter_e(at)gmx(dot)net 75262 Uppsala
http://yi.org/peter-e/ Sweden

In response to

  • Re: MD5 at 2000-05-09 17:26:27 from Tom Lane

Responses

  • Re: MD5 at 2000-05-10 16:38:37 from Tom Lane

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-05-10 16:38:37 Re: MD5
Previous Message Malcolm Beattie 2000-05-10 16:28:52 Re: pg_hba.conf && ident ...