From: | The Hermit Hacker <scrappy(at)hub(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Vadim Mikheev <vadim(at)krs(dot)ru>, PostgreSQL Developers List <hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Re: [COMMITTERS] 'pgsql/src/backend/storage/buffer bufmgr.c' |
Date: | 1999-05-29 22:44:09 |
Message-ID: | Pine.BSF.4.05.9905291943160.446-100000@thelab.hub.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, 29 May 1999, Tom Lane wrote:
> Vadim Mikheev <vadim(at)krs(dot)ru> writes:
> >> bufmgr.c
> >> Log Message:
> >> Missing semicolons in non-HAS_TEST_AND_SET code paths :-(
>
> > Thanks, Tom!
> > I must say that I never tested non-Has_TEST_AND_SET case.
>
> I haven't either --- but those two places stuck out like sore thumbs
> after the pgindent run...
>
> This suggests that none of the beta-testing group uses a machine that
> doesn't have TEST_AND_SET support. I suppose that's good news about the
> coverage of s_lock.h, but it makes me worry that the non-TEST_AND_SET
> code hasn't even been compiled, let alone exercised. Someone ought to
> build and test a copy with TEST_AND_SET deliberately removed from the
> port.h file.
MIght this not indicate that that code is, in fact, useless? Designed for
older OSs that didn't have appropriate support?
Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org
From | Date | Subject | |
---|---|---|---|
Next Message | Henry B. Hotz | 1999-05-29 22:49:57 | Re: [HACKERS] Daemon News article |
Previous Message | Bruce Momjian | 1999-05-29 22:28:37 | Re: [HACKERS] Daemon News article |