Vadim Mikheev <vadim(at)krs(dot)ru> writes:
>> bufmgr.c
>> Log Message:
>> Missing semicolons in non-HAS_TEST_AND_SET code paths :-(
> Thanks, Tom!
> I must say that I never tested non-Has_TEST_AND_SET case.
I haven't either --- but those two places stuck out like sore thumbs
after the pgindent run...
This suggests that none of the beta-testing group uses a machine that
doesn't have TEST_AND_SET support. I suppose that's good news about the
coverage of s_lock.h, but it makes me worry that the non-TEST_AND_SET
code hasn't even been compiled, let alone exercised. Someone ought to
build and test a copy with TEST_AND_SET deliberately removed from the
port.h file.
regards, tom lane