| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Shlok Kyal' <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Fabrice Chapuis <fabrice636861(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Alexander Kukushkin <cyberdemn(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: issue with synchronized_standby_slots |
| Date: | 2025-10-27 04:05:49 |
| Message-ID: | OSCPR01MB14966A3AB03076B5F3C1F287FF5FCA@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Shlok,
> I agree that .pg_reload_conf() is not required. I have removed it in
> the latest version of patches.
Thanks for updating the patch!
After considering bit more, I started to feel the test should be under the
test/modules/unsafe_tests. Adding test requires that wal_level >= replica and
max_logical_replication_slots >= 1, but `make installcheck` might allow to run
such an environment. unsafe_tests can ensure that test would be run only while
`make check`. Also, ALTER SYSTEM requires to be superuser and the test has
already used the privileges.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2025-10-27 04:24:16 | Re: Use BumpContext contexts for TupleHashTables' tablecxt |
| Previous Message | Tom Lane | 2025-10-27 03:55:38 | Re: Use BumpContext contexts for TupleHashTables' tablecxt |