| From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Fabrice Chapuis <fabrice636861(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Alexander Kukushkin <cyberdemn(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: issue with synchronized_standby_slots |
| Date: | 2025-10-27 04:24:18 |
| Message-ID: | CANhcyEU+UwhUUow=vNXu=XAk=Z0i5ou9tChRFtoNmVn=1JBR7g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 27 Oct 2025 at 09:35, Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Shlok,
>
> > I agree that .pg_reload_conf() is not required. I have removed it in
> > the latest version of patches.
>
> Thanks for updating the patch!
> After considering bit more, I started to feel the test should be under the
> test/modules/unsafe_tests. Adding test requires that wal_level >= replica and
> max_logical_replication_slots >= 1, but `make installcheck` might allow to run
> such an environment. unsafe_tests can ensure that test would be run only while
> `make check`. Also, ALTER SYSTEM requires to be superuser and the test has
> already used the privileges.
>
Hi Kuroda-san,
I also agree with the analysis. I have added the test in 'guc_privs.sql'.
Thanks,
Shlok Kyal
| Attachment | Content-Type | Size |
|---|---|---|
| v10_REL_18-0001-Remove-the-validation-from-the-GUC-check-.txt | text/plain | 5.6 KB |
| v10_HEAD-0001-Remove-the-validation-from-the-GUC-check-ho.patch | application/octet-stream | 6.1 KB |
| v10_REL_17-0001-Remove-the-validation-from-the-GUC-check-.txt | text/plain | 5.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | David Rowley | 2025-10-27 04:24:16 | Re: Use BumpContext contexts for TupleHashTables' tablecxt |