| From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Fabrice Chapuis <fabrice636861(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Alexander Kukushkin <cyberdemn(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: issue with synchronized_standby_slots |
| Date: | 2025-10-24 10:34:09 |
| Message-ID: | CANhcyEXKyF82yDqb34W-=snfwbBzmWjWe=UHt+Z7iCssiqdrsQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 24 Oct 2025 at 15:08, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Fri, Oct 24, 2025 at 1:24 PM Hayato Kuroda (Fujitsu)
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> >
> > Dear Shlok,
> >
> > ```
> > -- Can set synchronized_standby_slots to a non-existent slot name.
> > ALTER SYSTEM SET synchronized_standby_slots='missing';
> > SELECT pg_reload_conf();
> >
> > -- Reset the GUC.
> > ALTER SYSTEM RESET synchronized_standby_slots;
> > SELECT pg_reload_conf();
> > ```
> >
> > pg_reload_conf() is called twice here but I'm not sure it is really needed.
> > ALTER SYSTEM itself can validate parameters via parse_and_validate_value(elevel=ERROR),
> > and pg_reload_conf() won't affect synchronously.
>
> I also think pg_reload_conf() won't be required here.
>
I agree that .pg_reload_conf() is not required. I have removed it in
the latest version of patches.
Thanks,
Shlok Kyal
| Attachment | Content-Type | Size |
|---|---|---|
| v9_REL_18-0001-Remove-the-validation-from-the-GUC-check-h.txt | text/plain | 5.1 KB |
| v9_HEAD-0001-Remove-the-validation-from-the-GUC-check-hoo.patch | application/x-patch | 5.6 KB |
| v9_REL_17-0001-Remove-the-validation-from-the-GUC-check-h.txt | text/plain | 5.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2025-10-24 11:13:04 | Re: Avoid resource leak (src/test/regress/pg_regress.c) |
| Previous Message | Ashutosh Bapat | 2025-10-24 10:09:37 | Re: Should we say "wal_level = logical" instead of "wal_level >= logical" |