Re: a couple of small cleanup patches for DSM-related code

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: a couple of small cleanup patches for DSM-related code
Date: 2025-06-05 01:20:09
Message-ID: aEDwyYrszNbgtDiE@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 04, 2025 at 01:53:06PM -0700, Masahiko Sawada wrote:
> It seems okay to me to commit it to HEAD as it's a cosmetic change and
> improves the consistency between v18 and 19.

Right. It looks confusing to leave these at 0 rather than NULL as
they mean a pointer, for the same reasons as what you have documented
in 5fe08c006c82. Doing that now or waiting for v19 does not make much
difference. Anyway, there's always the less-noise-when-backpatching
argument, so if you apply that now on HEAD that's fine IMO.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2025-06-05 01:41:47 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands
Previous Message Hayato Kuroda (Fujitsu) 2025-06-05 01:18:54 Missing program_XXX calling in pgbench tests