RE: [PATCH] pg_walsummary: suppress limit output with --quiet

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Fujii Masao' <masao(dot)fujii(at)gmail(dot)com>, "Koshi Shibagaki (Fujitsu)" <shibagaki(dot)koshi(at)fujitsu(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: [PATCH] pg_walsummary: suppress limit output with --quiet
Date: 2026-10-07 01:56:43
Message-ID: OS7PR01MB18317F7CE7D65C26AF925CF27F5942@OS7PR01MB18317.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Fujii-san,

> Thanks for updating the patch! LGTM.
>
> I've attached an updated version with some cosmetic changes and revised
> commit log messages. I also created a patch for REL_17_STABLE.

Thanks for updating the patch. One minor point: command_like() might be
better in below if we assume the command returns 0 and no stderr. But
not a strong opinion.

```
+command_checks_all([ 'pg_walsummary', '-q', @summaries ],
+ 0, [qr/\A\z/], [qr/\A\z/], "-q suppresses all output");
```

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-10-07 02:17:29 Re: REPACK (CONCURRENTLY) might keep dropped-column data
Previous Message Michael Paquier 2026-10-07 01:43:46 Re: Fix reindexdb with parallel index-level conrurrent run