| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Koshi Shibagaki (Fujitsu)" <shibagaki(dot)koshi(at)fujitsu(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] pg_walsummary: suppress limit output with --quiet |
| Date: | 2026-10-06 17:13:33 |
| Message-ID: | CAHGQGwGq8BJMV8j5=CQWZPEfAk97_2qLT0u7tN0inQTuY1m0MA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 5, 2026 at 5:46 PM Koshi Shibagaki (Fujitsu)
<shibagaki(dot)koshi(at)fujitsu(dot)com> wrote:
> Agreed. I tested the updated patch against REL_17_STABLE and
> REL_18_STABLE, and the pg_walsummary test suite passes on both.
> The patch applies cleanly to REL_18_STABLE. On REL_17_STABLE, the
> code change applies cleanly, but the test needs a small context
> adjustment because that branch does not contain the pg_stat_io check.
Thanks for updating the patch! LGTM.
I've attached an updated version with some cosmetic changes and revised
commit log messages. I also created a patch for REL_17_STABLE.
Barring any objections, I will commit it.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-pg_walsummary-quiet-to-suppress-limit-block-o.patch | application/octet-stream | 3.1 KB |
| nocfbot-v3-0001-PG17-Fix-pg_walsummary-quiet-to-suppress-limit-block-o.patch | application/octet-stream | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-10-06 17:46:47 | Re: Track skipped tables during autovacuum and autoanalyze |
| Previous Message | Peter Geoghegan | 2026-10-06 17:05:29 | Re: [PG19] eager aggregation gives wrong results because of bpchar_ops |