| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "Koshi Shibagaki (Fujitsu)" <shibagaki(dot)koshi(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] pg_walsummary: suppress limit output with --quiet |
| Date: | 2026-10-07 02:36:59 |
| Message-ID: | CAHGQGwF0vTo6xCWU-ZzAphS8beqdRRa3AZunXhEFUmDnSQ6b5A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 7, 2026 at 10:56 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> Thanks for updating the patch. One minor point: command_like() might be
> better in below if we assume the command returns 0 and no stderr. But
> not a strong opinion.
>
> ```
> +command_checks_all([ 'pg_walsummary', '-q', @summaries ],
> + 0, [qr/\A\z/], [qr/\A\z/], "-q suppresses all output");
> ```
Okay, I've replaced it with command_like(). How about the attached updated
patches?
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-v4-0001-PG17-Fix-pg_walsummary-quiet-to-suppress-limit-block-o.patch | application/octet-stream | 3.1 KB |
| v4-0001-Fix-pg_walsummary-quiet-to-suppress-limit-block-o.patch | application/octet-stream | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-10-07 02:40:01 | RE: [PATCH] pg_walsummary: suppress limit output with --quiet |
| Previous Message | shihao zhong | 2026-10-07 02:17:29 | Re: REPACK (CONCURRENTLY) might keep dropped-column data |