| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Nisha Moond' <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | "kehan5800(at)gmail(dot)com" <kehan5800(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: BUG #19892: Logical replication skips UPDATE/DELETE of rows with NULL in a hash-indexed subscriber column |
| Date: | 2026-11-16 13:08:12 |
| Message-ID: | OS7PR01MB1831708C979F230B56BA3D2B4F57C2@OS7PR01MB18317.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi,
> I don't see a comment under this one. Did you mean to suggest a change?
Opps, my mailer might not work well.
> > 01.
> > ```
> > +/*
> > + * Return true if 'searchslot' has a NULL in a key column of 'idxrel' and the
> > + * index can't search for NULLs (e.g. hash). Such a scan finds nothing.
> > + */
> > +static bool
> > +replindex_key_unsearchable(Relation idxrel, TupleTableSlot *searchslot)
> > ```
The function name might be too strong because it only checks whether the index
can take care NULL and/or the searchslot has NULL column. How about
replindex_key_has_unsearchable_null() or similar? We can rename again if we
find one or two more reasons to choose a fallback seq scan.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rajesh Kumar Thandapani | 2026-11-16 13:36:18 | Re: Re: Re: BUG #19776: pg_combinebackup ignores the truncation_block_length of an intermediate incremental backup |
| Previous Message | Bjorn Pagen | 2026-11-16 12:38:45 | Re: BUG #19907: INSERT through partitioned table fails with domain-typed generated column |