| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "kehan5800(at)gmail(dot)com" <kehan5800(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #19892: Logical replication skips UPDATE/DELETE of rows with NULL in a hash-indexed subscriber column |
| Date: | 2026-11-16 12:19:26 |
| Message-ID: | CABdArM6anJ4dRyxr3HkU+D8-6Zj0Vga2LG4yu1MzN2iHR+pE2A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Nov 16, 2026 at 1:31 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Hi Ke and Nisha,
>
> Good catch and thanks for working on it.
> I was an author of edca3424342, which allowed to use hash index while finding
> tuples for REPLICA IDENTITY FULL case. Sadly, I have not known the handling of
> NULL by hash index, my fault.
>
> I reviewed the proposed patch and basically LGTM. As for the test code, I confirmed
> they could fail before fixing the source and can pass after that.
> Few comments:
>
> 01.
> ```
> +/*
> + * Return true if 'searchslot' has a NULL in a key column of 'idxrel' and the
> + * index can't search for NULLs (e.g. hash). Such a scan finds nothing.
> + */
> +static bool
> +replindex_key_unsearchable(Relation idxrel, TupleTableSlot *searchslot)
> ```
>
I don't see a comment under this one. Did you mean to suggest a change?
--
Nisha
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-11-16 12:23:11 | Re: BUG #19905: loread() with length near INT_MAX: "invalid memory alloc request size" (int32 overflow) |
| Previous Message | Andrey Borodin | 2026-11-16 12:08:50 | Re: Timing issue in pg_basebackup |