| From: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "kehan5800(at)gmail(dot)com" <kehan5800(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #19892: Logical replication skips UPDATE/DELETE of rows with NULL in a hash-indexed subscriber column |
| Date: | 2026-11-16 15:15:40 |
| Message-ID: | CABdArM5WQMBMwvD0WSj7-U6u6ErCXtQV0v3Doz7X2Ktbp-YS=Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Nov 16, 2026 at 6:38 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Hi,
>
> > I don't see a comment under this one. Did you mean to suggest a change?
>
> Opps, my mailer might not work well.
>
> > > 01.
> > > ```
> > > +/*
> > > + * Return true if 'searchslot' has a NULL in a key column of 'idxrel' and the
> > > + * index can't search for NULLs (e.g. hash). Such a scan finds nothing.
> > > + */
> > > +static bool
> > > +replindex_key_unsearchable(Relation idxrel, TupleTableSlot *searchslot)
> > > ```
>
> The function name might be too strong because it only checks whether the index
> can take care NULL and/or the searchslot has NULL column. How about
> replindex_key_has_unsearchable_null() or similar? We can rename again if we
> find one or two more reasons to choose a fallback seq scan.
>
Thanks for the review, renamed it to replindex_key_has_unsearchable_null().
I also made the suggested changes 02 & 03 at [1]. The updated patch is attached.
[1] https://www.postgresql.org/message-id/OS7PR01MB1831731C0A17AAED9DA406AAEF57C2%40OS7PR01MB18317.jpnprd01.prod.outlook.com
--
Thanks,
Nisha
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-lookup-of-rows-with-NULL-keys-through-a-hash-.patch | application/octet-stream | 10.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2026-11-16 15:46:23 | Re: BUG #19892: Logical replication skips UPDATE/DELETE of rows with NULL in a hash-indexed subscriber column |
| Previous Message | PG Bug reporting form | 2026-11-16 14:08:50 | BUG #19908: pg_upgrade --check crashes instance if running in a different PID Namespace then the old cluster |