| From: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Fixup some appendStringInfo and appendPQExpBuffer calls |
| Date: | 2021-06-02 01:37:51 |
| Message-ID: | OS0PR01MB5716732158B1C4142C6FE375943D9@OS0PR01MB5716.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
In the latest HEAD branch, I found some places were using
appendStringInfo/appendPQExpBuffer() when they could have been using
appendStringInfoString/ appendPQExpBufferStr() instead. I think we'd better
fix these places in case other developers will use these codes as a reference,
though, it seems will not bring noticeable performance gain.
Attaching a patch to fix these places.
Best regards,
houzj
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fixup-some-appendStringInfo-and-appendPQExpBuffer-ca.patch | application/octet-stream | 4.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-06-02 01:49:01 | TAP tests still sensitive to various PG* environment variables |
| Previous Message | Michael Paquier | 2021-06-02 01:14:10 | Re: return correct error code from pgtls_init |