| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fixup some appendStringInfo and appendPQExpBuffer calls |
| Date: | 2021-06-02 10:57:01 |
| Message-ID: | 202106021057.olomemdqjocu@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021-Jun-02, houzj(dot)fnst(at)fujitsu(dot)com wrote:
> Hi,
>
> In the latest HEAD branch, I found some places were using
> appendStringInfo/appendPQExpBuffer() when they could have been using
> appendStringInfoString/ appendPQExpBufferStr() instead. I think we'd better
> fix these places in case other developers will use these codes as a reference,
> though, it seems will not bring noticeable performance gain.
hmm why didn't we get warnings about the PENDING DETACH one? Maybe we
need some decorator in PQExpBuffer.
--
Álvaro Herrera 39°49'30"S 73°17'W
"La espina, desde que nace, ya pincha" (Proverbio africano)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | tanghy.fnst@fujitsu.com | 2021-06-02 11:06:41 | RE: tab-complete for CREATE TYPE ... SUBSCRIPT |
| Previous Message | Bharath Rupireddy | 2021-06-02 10:14:45 | Re: Alias collision in `refresh materialized view concurrently` |