Re: Fixup some appendStringInfo and appendPQExpBuffer calls

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Date: 2021-06-02 04:29:26
Message-ID: YLcJJnSz6YR7IMkz@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 02, 2021 at 01:37:51AM +0000, houzj(dot)fnst(at)fujitsu(dot)com wrote:
> In the latest HEAD branch, I found some places were using
> appendStringInfo/appendPQExpBuffer() when they could have been using
> appendStringInfoString/ appendPQExpBufferStr() instead. I think we'd better
> fix these places in case other developers will use these codes as a reference,
> though, it seems will not bring noticeable performance gain.

Indeed, that's the same thing as 110d817 to make all those calls
cheaper. No objections from me to do those changes now rather than
later on HEAD.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-06-02 05:05:44 Re: Speed up pg_checksums in cases where checksum already set
Previous Message Amit Kapila 2021-06-02 04:12:23 Re: Decoding speculative insert with toast leaks memory