| From: | Japin Li <japinli(at)hotmail(dot)com> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Roman Khapov <rkhapov(at)yandex-team(dot)ru> |
| Subject: | Re: GIN pageinspect support for entry tree and posting tree |
| Date: | 2026-01-14 02:19:02 |
| Message-ID: | MEAPR01MB3031127CF9A8C02399E2D0ABB68FA@MEAPR01MB3031.ausprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 11 Jan 2026 at 21:43, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>> On 10 Jan 2026, at 19:17, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>>
>> So,
>> v14-0004 with this change attached.
>
> Did you mean 0003?
>
> The change makes sense, but I'd note that macro is always used like this:
>
> if (!IS_INDEX(indexRel) || !IS_HASH(indexRel))
>
> If we are refactoring this, maybe put IS_INDEX inside of corresponding IS_BTREE(),IS_GIN() and IS_HASH()?
>
+1
Attach the v15 patch.
v15-0001 and v15-0002 unchanged and v15-0003 changed as above.
--
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
| Attachment | Content-Type | Size |
|---|---|---|
| v15-0001-Modernize-coding-in-GIN-pageinspect-functions.patch | text/x-patch | 5.4 KB |
| v15-0002-GIN-pageinspect-support-for-entry-tree-and-posti.patch | text/x-patch | 30.1 KB |
| v15-0003-Move-IS_INDEX-macro-to-pageinspect.h.patch | text/x-patch | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-14 02:26:07 | Re: Buffer locking is special (hints, checksums, AIO writes) |
| Previous Message | Peter Smith | 2026-01-14 02:17:45 | Re: Proposal: Conflict log history table for Logical Replication |