Quick Links

Re: GIN pageinspect support for entry tree and posting tree

From:	Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To:	Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc:	Japin Li <japinli(at)hotmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Roman Khapov <rkhapov(at)yandex-team(dot)ru>
Subject:	Re: GIN pageinspect support for entry tree and posting tree
Date:	2026-01-11 16:43:41
Message-ID:	BFCA6110-EC97-4569-917A-747A72F62CE8@yandex-team.ru
Views:	Whole Thread \| Raw Message \| Download mbox \| Resend email
Thread:
Lists:	pgsql-hackers

> On 10 Jan 2026, at 19:17, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
>
> So,
> v14-0004 with this change attached.

Did you mean 0003?

The change makes sense, but I'd note that macro is always used like this:

if (!IS_INDEX(indexRel) || !IS_HASH(indexRel))

If we are refactoring this, maybe put IS_INDEX inside of corresponding IS_BTREE(),IS_GIN() and IS_HASH()?

Best regards, Andrey Borodin.

	From	Date	Subject
Next Message	David E. Wheeler	2026-01-11 16:47:27	Re: ABI Compliance Checker GSoC Project
Previous Message	Tom Lane	2026-01-11 16:19:30	Re: JumbleQuery ma treat different GROUP BY expr as the same