| From: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Roman Khapov <rkhapov(at)yandex-team(dot)ru> |
| Subject: | Re: GIN pageinspect support for entry tree and posting tree |
| Date: | 2026-01-14 09:42:54 |
| Message-ID: | CALdSSPg6cqqWNDkAWX0RfB7CXM+oxacHivHPa90dZtX27KBGLg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 14 Jan 2026 at 07:19, Japin Li <japinli(at)hotmail(dot)com> wrote:
>
> On Sun, 11 Jan 2026 at 21:43, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
> >> On 10 Jan 2026, at 19:17, Kirill Reshke <reshkekirill(at)gmail(dot)com> wrote:
> >>
> >> So,
> >> v14-0004 with this change attached.
> >
> > Did you mean 0003?
> >
> > The change makes sense, but I'd note that macro is always used like this:
> >
> > if (!IS_INDEX(indexRel) || !IS_HASH(indexRel))
> >
> > If we are refactoring this, maybe put IS_INDEX inside of corresponding IS_BTREE(),IS_GIN() and IS_HASH()?
> >
>
> +1
>
> Attach the v15 patch.
> v15-0001 and v15-0002 unchanged and v15-0003 changed as above.
>
> --
> Regards,
> Japin Li
> ChengDu WenWu Information Technology Co., Ltd.
>
Hi! Thank you 🙏 for your effort. 0003 looks good to me
--
Best regards,
Kirill Reshke
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-01-14 09:50:25 | Re: Simplify code building the LR conflict messages |
| Previous Message | Álvaro Herrera | 2026-01-14 09:36:24 | Re: Segmentation fault on proc exit after dshash_find_or_insert |