Re: [PATCH] Fix alter subscription concurrency errors

From: Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix alter subscription concurrency errors
Date: 2022-08-26 08:05:02
Message-ID: HE1PR8303MB0075B62308DEDDD77D8B3D99F7759@HE1PR8303MB0075.EURPRD83.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Won't the same thing can happen for similar publication commands? Why
> is this unique to the subscription and not other Alter/Drop commands?

I indeed don't think this problem is unique to subscriptions, but it seems
better to at least have this problem in a few places less (not making perfect
the enemy of good).

If someone has a more generic way of solving this for other commands too,
then that sounds great, but if not then slowly chipping away at these cases
seems better than keeping the status quo.

Attached is a new patch where ALTER SUBSCRIPTION ... OWNER TO ... can
now also be executed concurrently with the other subscription commands.

Attachment Content-Type Size
0001-Fix-errors-when-concurrently-altering-subscriptions.patch application/octet-stream 18.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2022-08-26 08:18:04 Re: Asynchronous execution support for Custom Scan
Previous Message Kyotaro Horiguchi 2022-08-26 08:04:32 Re: pg_rewind WAL segments deletion pitfall