Re: [PATCH] Fix alter subscription concurrency errors

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix alter subscription concurrency errors
Date: 2022-08-26 02:11:00
Message-ID: CAA4eK1L1Si=SpUW_2DKz2fHZEioKXOBe0vj5QqyOdwnW1B27yg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Aug 25, 2022 at 8:17 PM Jelte Fennema
<Jelte(dot)Fennema(at)microsoft(dot)com> wrote:
>
> Without this patch concurrent ALTER/DROP SUBSCRIPTION statements for
> the same subscription could result in one of these statements returning the
> following error:
>
> ERROR: XX000: tuple concurrently updated
>
> This patch fixes that by re-fetching the tuple after acquiring the lock on the
> subscription. The included isolation test fails most of its permutations
> without this patch, with the error shown above.
>

Won't the same thing can happen for similar publication commands? Why
is this unique to the subscription and not other Alter/Drop commands?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-08-26 02:55:27 Re: pg_stat_wal: tracking the compression effect
Previous Message Michael Paquier 2022-08-26 02:09:41 Re: [PATCH] Add native windows on arm64 support