From: | Asif Rehman <asifr(dot)rehman(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: [PATCH] Fix alter subscription concurrency errors |
Date: | 2022-08-31 10:29:58 |
Message-ID: | 166194179843.1087.2373013188766430306.pgcf@coridan.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation: not tested
The patch applies with few "Hunk succeeded, offset -3 lines" warnings. Tested against master '7d5852ca'.
+ if (!HeapTupleIsValid(tup))
+ {
+ if (!missing_ok)
+ ereport(ERROR,
+ (errcode(ERRCODE_UNDEFINED_OBJECT),
+ errmsg("subscription \"%s\" does not exist",
+ subname)));
+ else
+ ereport(NOTICE,
+ (errmsg("subscription \"%s\" does not exist, skipping",
+ subname)));
+
+ return InvalidOid;
+ }
+
I think 'tup' should be released before returning, or break out of loop instead to release it.
The new status of this patch is: Waiting on Author
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2022-08-31 10:36:40 | Re: Handle infinite recursion in logical replication setup |
Previous Message | Christoph Berg | 2022-08-31 09:59:29 | Re: plpgsql-trigger.html: Format TG_ variables as table (patch) |