From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Small documentation improvement for ALTER SUBSCRIPTION |
Date: | 2021-09-07 12:01:14 |
Message-ID: | E8FD84DD-3FFE-47E0-84BB-B50149F671E1@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 7 Sep 2021, at 13:36, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> On 12.08.21 04:52, Masahiko Sawada wrote:
>> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>>
>>>> On 11 Aug 2021, at 09:57, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>>
>>>> Additionally, refresh options as described in
>>>> <replaceable>refresh_option</replaceable> of
>>>> <literal>REFRESH PUBLICATION</literal> may be specified,
>>>> except in the case of <literal>DROP PUBLICATION</literal>.
>>>
>>> Since this paragraph is under the literal option “refresh”, which takes a
>>> value, I still find your original patch to be the clearest.
>> Yeah, I prefer my original patch over this idea. On the other hand, I
>> can see the point of review comment on it that Amit pointed out[1].
>
> How about this:
>
> - Additionally, refresh options as described
> - under <literal>REFRESH PUBLICATION</literal> may be specified.
> + Additionally, the options described under <literal>REFRESH
> + PUBLICATION</literal> may be specified, to control the implicit refresh
> + operation.
LGTM.
--
Daniel Gustafsson https://vmware.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2021-09-07 12:04:23 | Re: OpenSSL 3.0.0 compatibility |
Previous Message | Zhihong Yu | 2021-09-07 11:50:15 | Re: Non-decimal integer literals |