| From: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Non-decimal integer literals |
| Date: | 2021-09-07 11:50:15 |
| Message-ID: | CALNJ-vT2qZ-hbfDAjutsYXfR+ga1-KMKtU2vRC0UtKbFeHCPfg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 7, 2021 at 4:13 AM Peter Eisentraut <
peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> On 16.08.21 17:32, John Naylor wrote:
> > The one thing that jumped out at me on a cursory reading is
> > the {integer} rule, which seems to be used nowhere except to
> > call process_integer_literal, which must then inspect the token text to
> > figure out what type of integer it is. Maybe consider 4 separate
> > process_*_literal functions?
>
> Agreed, that can be done in a simpler way. Here is an updated patch.
>
Hi,
Minor comment:
+SELECT int4 '0o112';
Maybe involve digits of up to 7 in the octal test case.
Thanks
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-09-07 12:01:14 | Re: Small documentation improvement for ALTER SUBSCRIPTION |
| Previous Message | Justin Pryzby | 2021-09-07 11:49:03 | Re: when the startup process doesn't (logging startup delays) |