Re: Small documentation improvement for ALTER SUBSCRIPTION

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small documentation improvement for ALTER SUBSCRIPTION
Date: 2021-09-07 11:36:43
Message-ID: 10ad233b-f1e8-4d7f-38a7-c249abb18848@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 12.08.21 04:52, Masahiko Sawada wrote:
> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>>> On 11 Aug 2021, at 09:57, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>>
>>> Additionally, refresh options as described in
>>> <replaceable>refresh_option</replaceable> of
>>> <literal>REFRESH PUBLICATION</literal> may be specified,
>>> except in the case of <literal>DROP PUBLICATION</literal>.
>>
>> Since this paragraph is under the literal option “refresh”, which takes a
>> value, I still find your original patch to be the clearest.
>
> Yeah, I prefer my original patch over this idea. On the other hand, I
> can see the point of review comment on it that Amit pointed out[1].

How about this:

- Additionally, refresh options as described
- under <literal>REFRESH PUBLICATION</literal> may be specified.
+ Additionally, the options described under <literal>REFRESH
+ PUBLICATION</literal> may be specified, to control the implicit
refresh
+ operation.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-09-07 11:39:58 Re: Added schema level support for publication.
Previous Message kuroda.hayato@fujitsu.com 2021-09-07 11:30:27 RE: Allow escape in application_name (was: [postgres_fdw] add local pid to fallback_application_name)