| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me> |
| Subject: | Re: Prevent an error on attaching/creating a DSM/DSA from an interrupt handler. |
| Date: | 2025-05-20 09:56:43 |
| Message-ID: | 65EB9E45-BD41-4DA7-A689-7A358CF7826F@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 20 May 2025, at 04:29, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I want to argue for reverting, at least for v18. I do not think that
> ProcessGetMemoryContextInterrupt is anywhere near release-quality.
> I found out while poking into Valgrind leak reports that it leaks
> memory --- and does so in TopMemoryContext.
Ugh, that's indeed a showstopper. Attached is a revert of the feature, I want
to re-read and re-test before pushing to make sure I didn't miss anything but
can go ahead with it later today.
--
Daniel Gustafsson
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Revert-function-to-get-memory-context-stats-for-proc.patch | application/octet-stream | 66.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2025-05-20 10:05:05 | Re: plan shape work |
| Previous Message | vignesh C | 2025-05-20 09:13:27 | Re: Make wal_receiver_timeout configurable per subscription |