| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove incorrect commented out code |
| Date: | 2026-01-22 11:51:12 |
| Message-ID: | E1vitDT-001zEv-1g@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove incorrect commented out code
These calls, if activated, are happening before null checks, so they
are not correct. Also, the "in" variable is shadowed later. Remove
them to avoid confusion and bad examples.
Reviewed-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Reviewed-by: David Geier <geidav(dot)pg(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/328e4371-9a4c-4196-9df9-1f23afc900df%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/846fb3c7901146a5450c08aeadf50566d5d65d09
Modified Files
--------------
src/backend/utils/adt/jsonfuncs.c | 4 ----
1 file changed, 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-01-22 13:47:28 | Re: pgsql: tests: Add a test C++ extension module |
| Previous Message | Peter Eisentraut | 2026-01-22 11:21:07 | pgsql: Remove redundant AssertVariableIsOfType uses |