pgsql: Remove redundant AssertVariableIsOfType uses

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove redundant AssertVariableIsOfType uses
Date: 2026-01-22 11:21:07
Message-ID: E1viskM-001yxi-1j@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove redundant AssertVariableIsOfType uses

The uses of AssertVariableIsOfType in pg_upgrade are unnecessary
because the calls to upgrade_task_add_step() already check the
compatibility of the callback functions.

These were apparently copied from a previous coding style, but similar
removals were already done in commit 30b789eafe.

Reviewed-by: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Reviewed-by: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/3d289481-7f76-409f-81c7-81824219cc75%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f3c96c9dff0c727afd1ef2ea976592c77cc809b5

Modified Files
--------------
src/bin/pg_upgrade/check.c | 23 -----------------------
src/bin/pg_upgrade/function.c | 2 --
src/bin/pg_upgrade/info.c | 5 -----
src/bin/pg_upgrade/version.c | 2 --
4 files changed, 32 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2026-01-22 11:51:12 pgsql: Remove incorrect commented out code
Previous Message Peter Eisentraut 2026-01-22 08:12:42 pgsql: Detect if flags are needed for C++11 support