| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: tests: Add a test C++ extension module |
| Date: | 2026-01-22 13:47:28 |
| Message-ID: | abb76852-0299-4b11-b487-862f1567f712@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 21.01.26 10:44, Peter Eisentraut wrote:
> On 21.01.26 09:50, Jelte Fennema-Nio wrote:
>> On Wed Jan 21, 2026 at 4:27 AM CET, Peter Smith wrote:
>>> 'make check-world' is suddenly failing for me, apparently caused by
>>> this new test.
>>>
>>> FYI - I am building in a 'Linux CentOS7-x64 ' environment, which I
>>> know has reached end-of-life, but even so, everything was fine before
>>> this test appeared.
>>
>>
>> I'm still not clear on what our policy is on supporting such EOL
>> distros. But this patch seems sensible regardless and it fixes
>> compilation for me when running on a centos 7 docker image.
>
> Yes, I was just in the process of writing that same patch. I'll see if
> there are any differences and then move ahead with this.
This has been committed, and at least one buildfarm member has confirmed
so far. The other ones are just very slow.
During testing, I noticed that my hack from an earlier patch to compute
have_cxx in configure didn't work well when you specify CXX from the
environment. So I implemented a different solution for that. Also, my
reading and testing showed that MSVC doesn't have a /std:c++11 option,
the oldest one is /std:c++14, so I went with that.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-01-22 15:07:15 | pgsql: Record range constructor functions in pg_range |
| Previous Message | Peter Eisentraut | 2026-01-22 11:51:12 | pgsql: Remove incorrect commented out code |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-01-22 14:20:45 | Re: CREATE TABLE LIKE INCLUDING TRIGGERS |
| Previous Message | Konstantin Knizhnik | 2026-01-22 13:45:09 | Re: Mystery with REVOKE PRIVILEGE |