pgsql: Remove check for accept() argument types

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove check for accept() argument types
Date: 2021-11-09 15:02:29
Message-ID: E1mkSdp-0008FH-7Y@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove check for accept() argument types

This check was used to accommodate a staggering variety in particular
in the type of the third argument of accept(). This is no longer of
concern on currently supported systems. We can just use socklen_t in
the code and put in a simple check that substitutes int for socklen_t
if it's missing, to cover the few stragglers.

Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://www.postgresql.org/message-id/3538f4c4-1886-64f2-dcff-aaad8267fb82@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ee3a1a5b636b69dde33d68c428dd56b3389a4538

Modified Files
--------------
aclocal.m4 | 1 -
config/ac_func_accept_argtypes.m4 | 78 -------------------------------------
configure | 82 ++++++---------------------------------
configure.ac | 2 +-
src/backend/libpq/auth.c | 2 +-
src/backend/libpq/pqcomm.c | 8 ++--
src/backend/postmaster/pgstat.c | 4 +-
src/include/libpq/pqcomm.h | 2 +-
src/include/pg_config.h.in | 15 ++-----
src/include/port.h | 4 ++
src/interfaces/libpq/fe-connect.c | 2 +-
src/port/getpeereid.c | 4 +-
src/tools/msvc/Solution.pm | 5 +--
13 files changed, 31 insertions(+), 178 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2021-11-09 19:35:46 pgsql: Have the server properly terminate tar archives.
Previous Message Tom Lane 2021-11-09 14:40:47 Re: pgsql: Fix incorrect format placeholder.