| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Remove check for accept() argument types |
| Date: | 2021-11-10 15:41:28 |
| Message-ID: | 1440792.1636558888@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> Remove check for accept() argument types
Early returns from the buildfarm are
gaur | 2021-11-09 16:55:58 | auth.c:3235:17: warning: pointer targets in passing argument 6 of 'recvfrom' differ in signedness
gaur | 2021-11-09 16:55:58 | pqcomm.c:722:9: warning: pointer targets in passing argument 3 of 'accept' differ in signedness
gaur | 2021-11-09 16:55:58 | pqcomm.c:743:6: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness
gaur | 2021-11-09 16:55:58 | pgstat.c:483:39: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness
gaur | 2021-11-09 16:55:58 | pgstat.c:630:9: warning: pointer targets in passing argument 5 of 'getsockopt' differ in signedness
gaur | 2021-11-09 16:55:58 | fe-connect.c:2760:11: warning: pointer targets in passing argument 5 of 'getsockopt' differ in signedness
gaur | 2021-11-09 16:55:58 | fe-connect.c:2788:9: warning: pointer targets in passing argument 3 of 'getsockname' differ in signedness
Right offhand I don't see any other animals complaining.
May I suggest that "unsigned int" would be a better choice
than "int" for socklen_t?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-11-10 18:13:28 | pgsql: Doc: improve protocol spec for logical replication Type messages |
| Previous Message | Robert Haas | 2021-11-10 15:18:11 | pgsql: Fix thinko in assertion in basebackup.c. |