| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com> |
| Subject: | Re: [RFC] building postgres with meson -v |
| Date: | 2021-11-04 18:17:05 |
| Message-ID: | 3538f4c4-1886-64f2-dcff-aaad8267fb82@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01.11.21 00:24, Andres Freund wrote:
> - remaining hardcoded configure tests (e.g. ACCEPT_TYPE_ARG*)
I think we can get rid of that one.
That test originally catered to some strange edge cases where the third
argument was size_t that was not the same size as int. That is long
gone, if it ever really existed. All systems currently of interest use
either socklen_t or int, and socklen_t is always int. (A few build farm
animals report size_t, but they are all 32-bit.)
I think we can change the code to use socklen_t and add a simple check
to typedef socklen_t as int if not available. See attached patch.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Remove-check-for-accept-argument-types.patch | text/plain | 15.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-11-04 18:48:13 | Re: [RFC] building postgres with meson -v |
| Previous Message | Fujii Masao | 2021-11-04 18:14:00 | Re: Allow escape in application_name |