pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Date: 2021-10-28 01:50:00
Message-ID: E1mfuYK-0004Bn-7O@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Add TAP test for archive_cleanup_command and recovery_end_command

This adds tests checking for the execution of both commands. The
recovery test 002_archiving.pl is nicely adapted to that, as promotion
is triggered already twice there, and even if any of those commands fail
they don't affect recovery or promotion.

A command success is checked using a file generated by an "echo"
command, that should be able to work in all the buildfarm environments,
even Msys (but we'll know soon about that). Command failure is tested
with an "echo" command that points to a path that does not exist,
scanning the backend logs to make sure that the failure happens. Both
rely on the backend triggering the commands from the root of the data
folder, making its logic more robust.

Thanks to Neha Sharma for the extra tests on Windows.

Author: Amul Sul, Michael Paquier
Reviewed-by: Andres Freund, Euler Taveira
Discussion: https://postgr.es/m/CAAJ_b95R_c4T5moq30qsybSU=eDzDHm=4SPiAWaiMWc2OW7=1Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/46dea2419ee7895a4eb3d048317682e6f18a17e1

Modified Files
--------------
src/test/recovery/t/002_archiving.pl | 47 +++++++++++++++++++++++++++++++++++-
1 file changed, 46 insertions(+), 1 deletion(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2021-10-28 02:45:24 Re: pgsql: Document XLOG_INCLUDE_XID a little better
Previous Message Michael Paquier 2021-10-28 00:27:26 pgsql: doc: Fix link to SELinux user guide in sepgsql page

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-10-28 01:54:08 Re: TAP test for recovery_end_command
Previous Message Kyotaro Horiguchi 2021-10-28 01:41:43 Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto