From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Document XLOG_INCLUDE_XID a little better |
Date: | 2021-10-28 02:45:24 |
Message-ID: | CAA4eK1KjQB0x5U80RMiOc8bCcTdkw97cahq6e8RrS6hoSFND5A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Oct 27, 2021 at 4:39 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>
> On Tue, Oct 26, 2021 at 9:19 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > >
> > > Thanks, both your patches look good to me except that we need to
> > > remove the sentence related to the revert of ade24dab97 from the
> > > commit message. I think we should backpatch the first patch to 14
> > > where it was introduced and commit the second patch (related to moving
> > > code out of critical section) only to HEAD but we can even backpatch
> > > the second one till 9.6 for the sake of consistency. What do you guys
> > > think?
> > >
> >
> > The other option could be to just commit both these patches in HEAD as
> > there is no correctness issue here.
>
> Right, even I feel we should just commit it to the HEAD as there is no
> correctness issue.
>
Thanks for your opinion. I'll commit it to the HEAD by next Tuesday
unless someone feels that we should backpatch this.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2021-10-28 13:32:58 | Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts(). |
Previous Message | Michael Paquier | 2021-10-28 01:50:00 | pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman |
From | Date | Subject | |
---|---|---|---|
Next Message | Bossart, Nathan | 2021-10-28 03:37:29 | inefficient loop in StandbyReleaseLockList() |
Previous Message | Bharath Rupireddy | 2021-10-28 02:43:58 | Re: Isn't it better with "autovacuum worker...." instead of "worker took too long to start; canceled" specific to "auto |