| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amul Sul <sulamul(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Euler Taveira <euler(at)eulerto(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: TAP test for recovery_end_command |
| Date: | 2021-10-28 01:54:08 |
| Message-ID: | YXoCwLYC7ZlYGa1t@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 27, 2021 at 02:20:50PM +0900, Michael Paquier wrote:
> ok(!-f $recovery_end_command_file,
> - 'recovery_end_command executed after promotion');
> + 'recovery_end_command not executed yet');
> Indeed :p
While looking at that this morning, I have noticed an extra bug. If
the path of the data folder included a space, the command would have
failed. I have to wonder if we should do something like
cp_history_files, but that did not seem necessary to me once we rely
on each command being executed from the root of the data folder.
Anyway, I am curious to see what the buildfarm thinks about all that,
particularly with Msys, so I have applied the patch. I am keeping an
eye on things, though.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-10-28 01:55:35 | Re: [PATCH] Fix memory corruption in pg_shdepend.c |
| Previous Message | Michael Paquier | 2021-10-28 01:50:00 | pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman |