| From: | "Tristan Partin" <tristan(at)partin(dot)io> |
|---|---|
| To: | "Niyaz Hazigaleyev" <hazigaleevniaz(at)gmail(dot)com> |
| Cc: | "Andres Freund" <andres(at)anarazel(dot)de>, "Elliot Haisley" <elliot(dot)haisley(at)outlook(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] meson: Update meson to enable building postgres as a subproject |
| Date: | 2026-01-05 23:53:42 |
| Message-ID: | DFH26TBGSU6W.3OH7HPP1FRK0L@partin.io |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon Jan 5, 2026 at 5:50 PM CST, Niyaz Hazigaleyev wrote:
> I also made a similar patch here
> https://www.postgresql.org/message-id/F28283CF-AC9C-4930-9D84-56CD9E105504%40gmail.com.
> I pretty much did the same thing but I also added postgres_inc to
> dependency because it cannot find postgres headers inside libpq’s
> headers. After looking at your patch i have few questions. Is
> meson.override_dependency(‘libpq’, libpq) really needed? It looks like
> it does nothing. In flex cmd args you removed —build-dir and
> —source-dir, was that necessary? Also when I was testing ur patch
> I couldn’t build libpq because of the problem with include directories
> of dependency that I mentioned. I attach the result patch with fix
> which only adds postgres_inc to libpq dependency include_directories
> to your patch.
I didn't have any problems with include directories, but it's possible
that my system corrupted my tests, as in my system includes supplemented
the missing subproject includes.
I removed the args from pgflex because they aren't used.
--
Tristan Partin
Databricks (https://databricks.com)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2026-01-05 23:55:00 | Reject Foreign Tables from MIN/MAX indexscan Optimization? |
| Previous Message | Masahiko Sawada | 2026-01-05 23:51:07 | Re: Fix incorrect buffer lock description in pg_visibility comment |