| From: | Niyaz Hazigaleyev <hazigaleevniaz(at)gmail(dot)com> |
|---|---|
| To: | Tristan Partin <tristan(at)partin(dot)io> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Elliot Haisley <elliot(dot)haisley(at)outlook(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] meson: Update meson to enable building postgres as a subproject |
| Date: | 2026-01-05 23:50:30 |
| Message-ID: | CF04FCAD-54E5-42B1-B777-FF433E779E4E@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I also made a similar patch here https://www.postgresql.org/message-id/F28283CF-AC9C-4930-9D84-56CD9E105504%40gmail.com. I pretty much did the same thing but I also added postgres_inc to dependency because it cannot find postgres headers inside libpq’s headers. After looking at your patch i have few questions. Is meson.override_dependency(‘libpq’, libpq) really needed? It looks like it does nothing. In flex cmd args you removed —build-dir and —source-dir, was that necessary?
Also when I was testing ur patch I couldn’t build libpq because of the problem with include directories of dependency that I mentioned. I attach the result patch with fix which only adds postgres_inc to libpq dependency include_directories to your patch.
| Attachment | Content-Type | Size |
|---|---|---|
| libpq.patch | application/octet-stream | 6.4 KB |
| unknown_filename | text/plain | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2026-01-05 23:50:38 | Re: LLVM 22 |
| Previous Message | Chao Li | 2026-01-05 23:44:56 | Re: Fix incorrect buffer lock description in pg_visibility comment |