| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix incorrect buffer lock description in pg_visibility comment |
| Date: | 2026-01-05 23:51:07 |
| Message-ID: | CAD21AoARCKbXGcSdsaguaWf9OBLycFFbrUzXLSHtRWJ7zZp6Dg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 5, 2026 at 3:45 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
>
>
> > On Jan 6, 2026, at 02:41, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I find that "shared locked" sounds unnatural to me. How about
> > rephrasing to "... we're holding the buffer locked in shared mode”?
>
> Hi Masahiko-san,
>
> Thanks for taking care of this patch. Yeah, I agree “shared locked” is not good, at least it should be “shared-ly locked”. So, Your version, “locked in shared mode” is better.
>
Thank you for reviewing the patch! Pushed.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tristan Partin | 2026-01-05 23:53:42 | Re: [PATCH] meson: Update meson to enable building postgres as a subproject |
| Previous Message | Thomas Munro | 2026-01-05 23:50:38 | Re: LLVM 22 |