| From: | "Matheus Alcantara" <matheusssilv97(at)gmail(dot)com> |
|---|---|
| To: | "Alexander Pyhalov" <a(dot)pyhalov(at)postgrespro(dot)ru>, "Matheus Alcantara" <matheusssilv97(at)gmail(dot)com> |
| Cc: | "Alena Rybakina" <a(dot)rybakina(at)postgrespro(dot)ru>, "Pgsql Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Asynchronous MergeAppend |
| Date: | 2025-12-29 13:43:00 |
| Message-ID: | DFAQTF8P9AU0.2ZELZFXOCD0XL@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue Dec 23, 2025 at 5:50 AM -03, Alexander Pyhalov wrote:
> I've looked through updated patch. Tested it (also with our fdw).
> Overall looks good.
>
Thanks for testing.
> In execAppend.c there's still reference to as_valid_subplans. Also we
> could perhaps use palloc0_array() in some more places, for example, for
> for state->asyncrequests and state->asyncresults.
>
Fixed on the new attached version.
--
Matheus Alcantara
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-mark_async_capable-subpath-should-match-subplan.patch | text/plain | 2.4 KB |
| v11-0002-MergeAppend-should-support-Async-Foreign-Scan-su.patch | text/plain | 50.3 KB |
| v11-0003-Create-execAppend.c-to-avoid-duplicated-code-on-.patch | text/plain | 85.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dharin Shah | 2025-12-29 13:45:27 | Re: Fwd: [PATCH] Add zstd compression for TOAST using extended header format |
| Previous Message | Daniil Davydov | 2025-12-29 13:39:36 | Wrong comment for ReplicationSlotCreate |