| From: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
|---|---|
| To: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Cc: | Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Asynchronous MergeAppend |
| Date: | 2025-12-30 13:15:45 |
| Message-ID: | c264abe661f72d6627f987fc9aa4e456@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Matheus Alcantara писал(а) 2025-12-29 16:43:
> On Tue Dec 23, 2025 at 5:50 AM -03, Alexander Pyhalov wrote:
>> I've looked through updated patch. Tested it (also with our fdw).
>> Overall looks good.
>>
> Thanks for testing.
>
>> In execAppend.c there's still reference to as_valid_subplans. Also we
>> could perhaps use palloc0_array() in some more places, for example,
>> for
>> for state->asyncrequests and state->asyncresults.
>>
> Fixed on the new attached version.
>
> --
> Matheus Alcantara
> EDB: https://www.enterprisedb.com
Hi.
Looks good. What do you think about classify_matching_subplans_common()?
Should it stay where it is or should we hide it to
src/include/executor/execAppend.h ?
--
Best regards,
Alexander Pyhalov,
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2025-12-30 14:05:53 | Re: REASSIGN OWNED BY alters objects in other database. |
| Previous Message | Kirill Reshke | 2025-12-30 12:59:11 | REASSIGN OWNED BY alters objects in other database. |