| From: | Daniil Davydov <3danissimo(at)gmail(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Wrong comment for ReplicationSlotCreate |
| Date: | 2025-12-29 13:39:36 |
| Message-ID: | CAJDiXggZXQZ7bD0QcTizDt6us9aX6ZKK4dWxzgb5x3+TsVHjqQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I noticed that the comment for ReplicationSlotCreate function contains this
description for the "two_phase" option :
* two_phase: Allows decoding of prepared transactions. We allow this option
* to be enabled only at the slot creation time. If we allow this option
* to be changed during decoding then it is quite possible that we skip
* prepare first time because this option was not enabled. Now next time
* during getting changes, if the two_phase option is enabled it can skip
* prepare because by that time start decoding point has been moved. So the
* user will only get commit prepared.
But commit [1] introduced the ability to alter the "two_phase" option for the
replication slot. Thus, I guess that the comment mentioned above is
outdated and we should change it.
[1] 1462aad2e4474ab61174f8ab00992cd3d6d57c7b
--
Best regards,
Daniil Davydov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-comment-for-ReplicationSlotCreate.patch | text/x-patch | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matheus Alcantara | 2025-12-29 13:43:00 | Re: Asynchronous MergeAppend |
| Previous Message | Konstantin Knizhnik | 2025-12-29 13:37:24 | Re: index prefetching |