Re: use of SPI by postgresImportForeignStatistics

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: use of SPI by postgresImportForeignStatistics
Date: 2026-07-10 07:40:51
Message-ID: CAPmGK17r6fPH21k6abF=qaQ96AnoJpv1SdOSayk4VHmp_8-fjw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii-san,

On Fri, Jul 10, 2026 at 2:37 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> In the committed patch, I found that the set_*_arg() helper functions
> in postgres_fdw.c are declared static in their prototypes, but their
> definitions omit the static keyword. This looks like an oversight.
>
> Attached patch adds static to the definitions for consistency and
> to make their intended file-local scope explicit. It also fixes a few
> nearby comment typos.

Good catch! Thanks for the patch! LGTM.

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Jones 2026-07-10 07:46:59 Re: Proposal: INSERT ... BY NAME
Previous Message Andreas Karlsson 2026-07-10 07:31:15 Re: Possible typo in an error message