| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: use of SPI by postgresImportForeignStatistics |
| Date: | 2026-07-10 05:36:40 |
| Message-ID: | CAHGQGwGjcQ4SwHMUQ9P8UYQ7iLKL1QE3uLSdONToQ1MrzpUUoQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 10, 2026 at 2:03 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
>
> On Wed, Jul 8, 2026 at 9:04 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> > Attached is a new version
> > of the patch. I'm planning to push and back-patch it, if no
> > objections.
>
> Committed and back-patched.
In the committed patch, I found that the set_*_arg() helper functions
in postgres_fdw.c are declared static in their prototypes, but their
definitions omit the static keyword. This looks like an oversight.
Attached patch adds static to the definitions for consistency and
to make their intended file-local scope explicit. It also fixes a few
nearby comment typos.
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-postgres_fdw-Mark-statistics-import-helpers-as-st.patch | application/octet-stream | 3.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | shveta malik | 2026-07-10 05:47:03 | Re: [PATCH] Preserve replication origin OIDs in pg_upgrade |
| Previous Message | Jeremy Schneider | 2026-07-10 05:19:55 | Re: hang during shutdown |