| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: use of SPI by postgresImportForeignStatistics |
| Date: | 2026-07-10 11:36:57 |
| Message-ID: | CAPmGK14hN-YXxPp-OeWZ6E8=YvT5SESh+NdcQywsdnV_AXsRiA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 10, 2026 at 4:40 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Fri, Jul 10, 2026 at 2:37 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> > In the committed patch, I found that the set_*_arg() helper functions
> > in postgres_fdw.c are declared static in their prototypes, but their
> > definitions omit the static keyword. This looks like an oversight.
> >
> > Attached patch adds static to the definitions for consistency and
> > to make their intended file-local scope explicit. It also fixes a few
> > nearby comment typos.
>
> Good catch! Thanks for the patch! LGTM.
My compiler (Apple clang version 17.0.0 (clang-1700.4.4.1)) doesn't
output any error/warning about that declaration. Actually, it's
allowed? Anyway, +1 for adding it for consistency.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nisha Moond | 2026-07-10 11:37:40 | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Previous Message | Nisha Moond | 2026-07-10 11:33:43 | Re: Support EXCEPT for TABLES IN SCHEMA publications |