| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, "gkokolatos(at)pm(dot)me" <gkokolatos(at)pm(dot)me>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | Re: Allow batched insert during cross-partition updates |
| Date: | 2022-12-14 09:44:48 |
| Message-ID: | CAPmGK16HE3kdZcig+E_OFg8z4YZNrwshZA8ju7Mwy9kU-91dZQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 8, 2022 at 8:01 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Thu, Dec 8, 2022 at 5:00 PM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
> > Updated patch attached.
>
> I will review the patch a bit more, but I think
> it would be committable.
One thing I noticed is this bit:
-- Clean up
-DROP TABLE batch_table, batch_cp_upd_test, batch_table_p0,
batch_table_p1 CASCADE;
+DROP TABLE batch_table, batch_table_p0, batch_table_p1,
batch_cp_upd_test, cmdlog CASCADE;
This would be nitpicking, but this as-proposed will not remove remote
tables created for foreign-table partitions of the partitioned table
‘batch_cp_upd_test’. So I modified this a bit further to remove them
as well. Also, I split this into two, for readability. Another thing
is a typo in a test-case comment: s/a single INSERTs/a single INSERT/.
I fixed it as well. Other than that, the patch looks good to me.
Attached is an updated patch. If there are no objections, I will
commit the patch.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Allow-batching-of-inserts-during-cross-partition-efujita.patch | application/octet-stream | 8.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2022-12-14 10:34:44 | Re: Support logical replication of DDLs |
| Previous Message | Daniel Gustafsson | 2022-12-14 09:40:45 | Re: pg_upgrade: Make testing different transfer modes easier |