Re: use of SPI by postgresImportForeignStatistics

From: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: use of SPI by postgresImportForeignStatistics
Date: 2026-08-14 09:59:00
Message-ID: CAPmGK165Wca5=vJQ4cD6Vyx=dPf84hR=yF1uExOYDP8_XM5rQA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 12, 2026 at 7:59 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Wed, Aug 12, 2026 at 2:31 AM Corey Huinker <corey(dot)huinker(at)gmail(dot)com> wrote:
> >> There is one thing I'd like to change for v19: the name of the option
> >> for this feature. We named it restore_stats because it used the
> >> pg_restore_*() functions [1], but it doesn't use them anymore; it uses
> >> import_*_statistics() instead, so I think we should rename it to
> >> import_stats if not too late. I think it also matches the names of
> >> functions added to postgres_fdw.c like import_fetched_statistics().
> >> What do you think?
> >
> > I think it's worth a quick patch...
>
> The patch looks good to me. I will push/backpatch it if there are no
> objections from others.

Done.

Best regards,
Etsuro Fujita

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2026-08-14 10:04:46 Re: First draft of PG 19 release notes
Previous Message Hayato Kuroda (Fujitsu) 2026-08-14 09:18:29 RE: Per-table resync for logical replication subscriptions