| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: use of SPI by postgresImportForeignStatistics |
| Date: | 2026-08-12 10:59:59 |
| Message-ID: | CAPmGK171MtRuoVXG-DOFu6dc06fzK1-qW6pgSV4MG-VBbfg-pA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 12, 2026 at 2:31 AM Corey Huinker <corey(dot)huinker(at)gmail(dot)com> wrote:
>> There is one thing I'd like to change for v19: the name of the option
>> for this feature. We named it restore_stats because it used the
>> pg_restore_*() functions [1], but it doesn't use them anymore; it uses
>> import_*_statistics() instead, so I think we should rename it to
>> import_stats if not too late. I think it also matches the names of
>> functions added to postgres_fdw.c like import_fetched_statistics().
>> What do you think?
>
> I think it's worth a quick patch...
The patch looks good to me. I will push/backpatch it if there are no
objections from others.
Thanks for the patch!
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2026-08-12 11:01:46 | Re: Better shared data structure management and resizable shared data structures |
| Previous Message | Nazir Bilal Yavuz | 2026-08-12 10:54:53 | Re: Add a pg_wal_preallocate() SQL function to eagerly create future WAL segments |