| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: First draft of PG 19 release notes |
| Date: | 2026-08-14 10:04:46 |
| Message-ID: | CAPmGK16Ox1TybQRMXFDwcN188j8xjQ==U3g7ri3__0dJX=ttNw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 9, 2026 at 6:15 PM Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> wrote:
> On Fri, May 8, 2026 at 8:08 AM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > On Tue, Apr 21, 2026 at 05:24:59AM -0700, Etsuro Fujita wrote:
> > > "Allow the retrieval of statistics from foreign data wrapper servers
> > > (Corey Huinker, Etsuro Fujita)"
> > >
> > > This is mentioned in the Additional Modules section, presumably
> > > because it was supported in postgres_fdw, but it isn't limited to
> > > postgres_fdw, so we should move it to the General Performance section?
> >
> > Well, the full text is:
> >
> > Allow the retrieval of statistics from foreign data wrapper servers
> > (Corey Huinker, Etsuro Fujita) §
> >
> > This is enabled for postgres_fdw by using the option restore_stats. The
> > default is for ANALYZE to retrieve rows from the remote server to
> > locally generate statistics.
> >
> > It clearly mentions in the detail that it applies only to postgres_fdw,
> > so I think it is already in the right section. While it technically can
> > be done by any FDW, it is now only postgres_fdw so people looking for
> > postgres_fdw improvements will find it in the Additional Modules
> > section. What we can do is to reword it to:
> >
> > --> Allow the retrieval of statistics from postgres_fdw foreign data wrapper servers
> > (Corey Huinker, Etsuro Fujita) §
> >
> > --> This is enabled by using the option restore_stats. The
> > default is for ANALYZE to retrieve rows from the remote server to
> > locally generate statistics.
> >
> > but I think this is worse because it sounds like it can _only_ ever be
> > done by postgres_fdw. However, if you prefer this I will make this
> > change.
> >
> > I avoided "General Performance" because frankly, it is only
> > postgres_fdw, and it not a "General" performance improvement, and we
> > have a section for postgres_fdw already.
>
> Agreed. I think the current text is fine.
We renamed the "restore_stats" option to "import_stats". See commit 9a08585e8.
Best regards,
Etsuro Fujita
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Etsuro Fujita | 2026-08-14 09:59:00 | Re: use of SPI by postgresImportForeignStatistics |